Avoid per-row Enumerator#next in CSV#each#362
Closed
donoghuc wants to merge 1 commit into
Closed
Conversation
External iteration via Enumerator#next uses a Fiber, cheap on CRuby but Fiber-per-row (native thread) on JRuby, so CSV.parse_line and CSV#each are ~10x slower there. Drive the parser with a block on fresh iteration; keep Enumerator#next only when #shift/#peek already started pull-based iteration, preserving shared consumption (rubyGH-260). Closes ruby#361
Member
|
How about #363? |
Author
|
Closing in favor of pr linked above |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External iteration via Enumerator#next uses a Fiber, cheap on CRuby but Fiber-per-row (native thread) on JRuby, so CSV.parse_line and CSV#each are ~10x slower there. Drive the parser with a block on fresh iteration; keep Enumerator#next only when #shift/#peek already started pull-based iteration, preserving shared consumption (GH-260).
Closes #361